This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 08/10] Move some code later in backtrace_command_1
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 28 Apr 2017 16:07:58 +0100
- Subject: Re: [RFA 08/10] Move some code later in backtrace_command_1
- Authentication-results: sourceware.org; auth=none
- References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-9-tom@tromey.com>
On 25/04/17 20:41, Tom Tromey wrote:
> PR backtrace/15584 notes that some code in backtrace_command_1 is not
> useful when frame filters are in use. This patch moves this code into
> the no-frame-filters "if". This also removes the unused local
> "trailing_level", which I noticed while moving the code around.
>
> ChangeLog
> 2017-04-25 Tom Tromey <tom@tromey.com>
>
> PR backtrace/15584:
> * stack.c (backtrace_command_1): Move some code into no-filters
> "if".
Reads much better now, thanks. LGTM
Cheers
Phil