This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Class-fy regcache
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Fri, 28 Apr 2017 16:03:15 +0100
- Subject: Re: [PATCH 1/4] Class-fy regcache
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D88C1C04BD54
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D88C1C04BD54
- References: <1493152106-3246-1-git-send-email-yao.qi@linaro.org> <1493389594-24434-1-git-send-email-yao.qi@linaro.org> <1493389594-24434-2-git-send-email-yao.qi@linaro.org>
On 04/28/2017 03:26 PM, Yao Qi wrote:
> @@ -320,84 +283,90 @@ make_cleanup_regcache_invalidate (struct regcache *regcache, int regnum)
> struct gdbarch *
> get_regcache_arch (const struct regcache *regcache)
> {
> - return regcache->descr->gdbarch;
> + return regcache->get_gdbarch ();
> }
This "get_" oddly stayed behind. I think you should rename
it to "arch()". (That's what we called the equivalent
method in struct gdb_disassembler.)
Otherwise looks good to me.
Thanks,
Pedro Alves