Re: [Patch] New gdbarch method "dwarf_cfa_op" and migrate SPARC to it

[Pedro Alves <palves at redhat dot com>]

On 04/26/2017 09:48 AM, Ivo Raisr wrote:
> 
> 
> On 25.4.2017 12:40, Jiong Wang wrote:
>> Thanks for the review.
>>
>> Ok for master? thanks
> 
> Updated patch was tested on sparc64-linux with no regressions.
> I.

Thanks Ivo.

In that case, patch is OK.  Please push.

(Please note that GDB puts rationale for changes in the git commit
log, not just a ChangeLog entry as GCC does in the svn logs.)

One tiny nit:

+		  if (!gdbarch_execute_dwarf_cfa_vendor_op (gdbarch, insn, fs))
+		    error (_("Call Frame Instruction %d in vendor extension "
+			     "space is not handled on this architecture."),
+			   insn);

here I'd suggest adding something like "insn " or "op " before the %d:

  Call Frame Instruction insn %d in ...
  Call Frame Instruction op %d in ...

Thanks,
Pedro Alves