This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/8] Python: Move and rename gdb.BtraceInstruction

"Wiederhake, Tim" <tim.wiederhake@intel.com> writes:

> This is an artifact of splitting up "BtraceInstruction" into
> "RecordInstruction" and "RecordGap".
>
> This function used to handle instruction objects as well as gaps. In
> the case of a gap, btrace_insn_get would return NULL for a gap. For
> gaps we do not have symbol_and_line information, so we return NONE.
>
> Now this function only handles instructions and cannot be called for
> RecordGap objects. If we end up with INSN equal to NULL, a python
> exception has been flagged by btrace_insn_from_recpy_insn and we
> return NULL accordingly.

Could you move these changes to patch 5/8?  I don't have other comments
to this patch.

-- 
Yao (齐尧)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]