This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] PR threads/20743: Don't attempt to suspend or resume exited threads.


On Tuesday, April 18, 2017 10:27:51 AM Simon Marchi wrote:
> On 2017-04-17 14:27, John Baldwin wrote:
> > On Friday, April 14, 2017 08:01:25 PM Luis Machado wrote:
> >> On 04/14/2017 05:40 PM, John Baldwin wrote:
> >> >> Otherwise i have no further comments. I assume you ran gdb's testsuite
> >> >> against this change and verified the results are sane?
> >> >
> >> > There were no regressions at least.  With the stock tree there are
> >> > several unexpected failures already which I will get to at some point.
> >> >
> >> 
> >> Great. I have no further comments.
> > 
> > To be clear (since I believe I messed this up before), I still need 
> > approval
> > from an approver?
> 
> I read both the v1 and v2 threads to get the context, the patch looks 
> good to me.  Pedro was fine with the ALL_NON_EXITED_THREADS approach as 
> well, so go ahead and push.  I think it should go in the 8.0 branch as 
> well.

Thanks, pushed to both.

-- 
John Baldwin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]