This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 03/31/2017 12:29 PM, Sergio Durigan Junior wrote:
This has been on my TODO list for a while. There's a really old bug about this (PR testsuite/8595), and there was no reason for environ.exp to be specific for hppa* targets. So this patch removes this constraint, modernizes the testcase, and cleans up some things. Most of the tests remained, and some were rewritten (especially the one that checks if "show environment" works, which is something kind of hard to do). As a bonus, I'm adding a separated info-program.exp file containing all the tests related to "info program" that were present on environ.exp. Tested locally, everything still passes.
I haven't gone through the entire patch, but i have a question. Was this exercised for bare-metal?
If not, please make sure this test works correctly on bare-metal targets before assuming it does just because it passes on Linux-hosted tests. Otherwise we may have spurious failures due to tests that are not supposed to be executed in a bare-metal environment.
If you don't have access to bare-metal testing, i could give this a try (it may take a couple days though) and report back.
Thanks, Luis
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |