This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/2] Remove dead code and "current" field from MI thread output doc
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Wed, 12 Apr 2017 14:06:09 -0400
- Subject: [PATCH 1/2] Remove dead code and "current" field from MI thread output doc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com;
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
The MI documentation says that -thread-info output contains a "current"
field in the current thread tuple, with the value "*". Current GDB
master does not do this, and I couldn't find any GDB version that did.
I suspect that it was never the case.
The code that would correspond to this in print_thread_info_1 is
essentially dead code. The calls to uiout->text end up in
mi_out::do_text, which is empty.
This patch removes the documentation bit and the dead code. This
"current" field is not necessary, since -thread-info outputs a
"current-thread-id" field.
gdb/ChangeLog:
* thread.c (print_thread_info_1): Remove dead code.
gdb/doc/ChangeLog:
* gdb.texinfo (GDB/MI Thread Commands): Remove "current" field
from -thread-info output.
---
gdb/doc/gdb.texinfo | 3 ---
gdb/thread.c | 10 +---------
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 300d78eefb..9e872763b2 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -28088,9 +28088,6 @@ The result is a list of threads. The following attributes are
defined for a given thread:
@table @samp
-@item current
-This field exists only for the current thread. It has the value @samp{*}.
-
@item id
The global identifier that @value{GDBN} uses to refer to the thread.
diff --git a/gdb/thread.c b/gdb/thread.c
index abfce71eda..74d0d65e02 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -1283,15 +1283,7 @@ print_thread_info_1 (struct ui_out *uiout, char *requested_threads,
chain2 = make_cleanup_ui_out_tuple_begin_end (uiout, NULL);
- if (uiout->is_mi_like_p ())
- {
- /* Compatibility. */
- if (tp->ptid == current_ptid)
- uiout->text ("* ");
- else
- uiout->text (" ");
- }
- else
+ if (!uiout->is_mi_like_p ())
{
if (tp->ptid == current_ptid)
uiout->field_string ("current", "*");
--
2.11.0