This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file

> Cc: gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Wed, 12 Apr 2017 15:45:59 +0100
> 
> On 04/12/2017 03:42 PM, Eli Zaretskii wrote:
> >> Cc: gdb-patches@sourceware.org
> >> From: Pedro Alves <palves@redhat.com>
> >> Date: Wed, 12 Apr 2017 15:07:02 +0100
> >>
> >>> The comment in i386-tdep.c says:
> >>>
> >>>   /* There are a few i386 architecture variants that differ only
> >>>      slightly from the generic i386 target.  For now, we don't give them
> >>>      their own source file, but include them here.  As a consequence,
> >>>      they'll always be included.  */
> >>>
> >>> If we are going to have a separate tdep file for such architectures,
> >>> let's do it for SVR4 as well.
> >>
> >> That can be done, but I don't see why it has to be in the same patch?
> > 
> > It doesn't.
> 
> So to be clear, are you OK with the patch as is?

Yes.  Sorry if it wasn't clear.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]