This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 05/17] Change increment_reading_symtab to return a scoped_restore

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 12 Apr 2017 08:31:43 -0600
Subject: Re: [RFA v2 05/17] Change increment_reading_symtab to return a scoped_restore
Authentication-results: sourceware.org; auth=none
References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-6-tom@tromey.com> <d7e42d5c-21bc-0ea0-6eca-c3bae7218f54@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I noticed that this makes the gdb_assert unreachable.

I changed the assert to ">= 0" and moved it before the return.

Tom

References:
- [RFA v2 00/17] miscellaneous C++-ification
  - From: Tom Tromey
- [RFA v2 05/17] Change increment_reading_symtab to return a scoped_restore
  - From: Tom Tromey
- Re: [RFA v2 05/17] Change increment_reading_symtab to return a scoped_restore
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]