Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file

[Pedro Alves <palves at redhat dot com>]

On 04/12/2017 03:07 PM, Pedro Alves wrote:
> On 04/12/2017 02:47 PM, Eli Zaretskii wrote:
>>> From: Pedro Alves <palves@redhat.com>
>>> Cc: Eli Zaretskii <eliz@gnu.org>
>>> Date: Wed, 12 Apr 2017 14:31:15 +0100
>>>
>>> I posit that this makes them easier to find.
>>>
>>> The other day while working on the wchar_t patch, I had a bit of
>>> trouble finding the DJGPP/go32 tdep bits.  My initial reaction was
>>> looking for a go32-specific tdep file, but there's none.
>>
>> Thanks, but why single out go32?  
> 
> Because incremental progress.

Specifically, the "trouble finding djgpp bits" I'm referring to
happened after you pointed me that djgpp needed a tweak too:

 https://sourceware.org/ml/gdb-patches/2017-03/msg00538.html

At first, I didn't see a tdep file and so I thought that I'd have
to add one, and maybe come up with a djgpp arch sniffer.  It took
me a few minutes to realize that we already have go32-specific
tdep bits in the generic i386 file.  So that's my only
motivation -- exactly to make it easier to spot the djgpp bits
quicker.  There's no other rationale behind this.  If I'll have to
go do more things to other ports to get this in, I'm afraid I'll
just drop the patch, because _I_ will have learned about them and
know next time where to look.

Thanks,
Pedro Alves