This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 06/14] Remove cleanup_iconv

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 10 Apr 2017 17:20:13 -0600
Subject: Re: [RFA 06/14] Remove cleanup_iconv
Authentication-results: sourceware.org; auth=none
References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-7-tom@tromey.com> <20f3123507be4351238bda8e0141958f@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> From what I understand about C++ constructors and destructors, the
Simon> check for -1 is unnecessary.  The destructor will only be called if
Simon> the constructor ran to completion.  If the constructor ran to
Simon> completion (didn't throw), m_desc won't be -1.

Yeah, that was just copy-paste from the other class, which may be wrong.
I changed this.

Tom

References:
- [RFA 00/14] miscellaneous C++-ificiation
  - From: Tom Tromey
- [RFA 06/14] Remove cleanup_iconv
  - From: Tom Tromey
- Re: [RFA 06/14] Remove cleanup_iconv
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]