This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 05 Apr 2017 12:45:56 -0400
- Subject: Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 30F9B61980
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 30F9B61980
- References: <20170405163129.24815-1-sergiodj@redhat.com> <8d200237-58fe-45c3-c0a6-2f15413a988b@redhat.com>
On Wednesday, April 05 2017, Pedro Alves wrote:
> On 04/05/2017 05:31 PM, Sergio Durigan Junior wrote:
>> This is an obvious fix for PR 21352. The problem is that the argument
>> parsing loop is not using an "else if" where it should, and therefore
>> the '-r' option ends up unrecognized by GDB.
>
> We have a few tests under gdb.trace/ that exercise "tsave". Would it
> be easy to augment some to exercise this?
Yes, absolutely. I was thinking about doing that but decided not too.
Anyway, here's what I checked in.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
>From 0ad9d8c73486e60c5a4963c1b7a0ea7063d69cd2 Mon Sep 17 00:00:00 2001
From: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Wed, 5 Apr 2017 12:43:52 -0400
Subject: [PATCH] PR 21352: Add testsuite for "tsave -r" command
This commit adds a test for the fix of PR 21352.
gdb/testsuite/ChangeLog:
2017-04-05 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/21352
* gdb.trace/tsv.exp: Add test for "tsave -r".
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.trace/tsv.exp | 4 ++++
2 files changed, 9 insertions(+)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index eb543eb..83d6018 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2017-04-05 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ PR gdb/21352
+ * gdb.trace/tsv.exp: Add test for "tsave -r".
+
2017-03-29 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.python/py-section-script.exp (sepdebug): New testcases.
diff --git a/gdb/testsuite/gdb.trace/tsv.exp b/gdb/testsuite/gdb.trace/tsv.exp
index 9da4669..2b80c80 100644
--- a/gdb/testsuite/gdb.trace/tsv.exp
+++ b/gdb/testsuite/gdb.trace/tsv.exp
@@ -26,6 +26,10 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
}
gdb_load $binfile
+# PR gdb/21352: Command tsave does not support -r argument
+gdb_test "tsave -r" "Argument required \\\(file in which to save trace data\\\)\." \
+ "tsave command properly supports -r argument"
+
gdb_test "tvariable \$tvar1" \
"Trace state variable \\\$tvar1 created, with initial value 0." \
"create a trace state variable"
--
2.9.3