This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 5 Apr 2017 17:34:06 +0100
- Subject: Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DFB9D7F7A7
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DFB9D7F7A7
- References: <20170405163129.24815-1-sergiodj@redhat.com>
On 04/05/2017 05:31 PM, Sergio Durigan Junior wrote:
> This is an obvious fix for PR 21352. The problem is that the argument
> parsing loop is not using an "else if" where it should, and therefore
> the '-r' option ends up unrecognized by GDB.
We have a few tests under gdb.trace/ that exercise "tsave". Would it
be easy to augment some to exercise this?
Thanks,
Pedro Alves