This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 15/18] -Wwrite-strings: execute_command calls with string literals
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Pedro Alves <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 5 Apr 2017 07:13:42 +0000
- Subject: RE: [PATCH 15/18] -Wwrite-strings: execute_command calls with string literals
- Authentication-results: sourceware.org; auth=none
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 10.0.102.7
- References: <1491326751-16180-1-git-send-email-palves@redhat.com> <1491326751-16180-16-git-send-email-palves@redhat.com>
Hello Pedro,
> All these places would better be calling some API function directly
> instead of going through execute_command & friends...
Ah, and I thought this is the preferred way.
The patch looks good to me. But I'm wondering if we should instead change
execute_command to take a const char *.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928