This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 1/5] Move parts of inferior job control to common/
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 31 Mar 2017 13:31:42 -0400
- Subject: Re: [PATCH v5 1/5] Move parts of inferior job control to common/
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9C37680B56
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9C37680B56
- References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170330014915.4894-1-sergiodj@redhat.com> <20170330014915.4894-2-sergiodj@redhat.com> <68a31f8b-d315-0ae7-6d2b-6811bce05766@redhat.com>
On Friday, March 31 2017, Pedro Alves wrote:
> On 03/30/2017 02:49 AM, Sergio Durigan Junior wrote:
>> gdb/gdbserver/ChangeLog:
>> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * Makefile.in (SFILE): Add "common/job-control.c".
>> (OBS): Add "job-control.o".
>> * terminal.h: Include "common-terminal.h".
>
> Is there a reason the .h and the .c files are named differently?
Hm, it's just because gdb_setpgid was defined on gdb/terminal.h, so I
thought it was better to move it to common-terminal.h (i.e., keep the
naming). Do you want a common/job-control.h?
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/