This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/5] dwarf2read.c: Make dir_index and file_name_index strong typedefs


On 2017-03-28 22:24, Pedro Alves wrote:
@@ -1169,7 +1179,7 @@ file_entry::include_dir (const line_header *lh) const
 {
   /* lh->include_dirs is 0-based, but the directory index numbers in
      the statement program are 1-based.  */
-  return lh->include_dir_at (dir_index - 1);
+  return lh->include_dir_at (to_underlying (d_index) - 1);

Should include_dir_at's parameter be a dir_index? At this point, exposing a zero based index in the line_header interface is exposing its internal implementation. Same for file_name_at.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]