This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5 v2] arc: Add disassembler helper
- From: Pedro Alves <palves at redhat dot com>
- To: Anton Kolesov <Anton dot Kolesov at synopsys dot com>, gdb-patches at sourceware dot org
- Cc: Francois Bedard <Francois dot Bedard at synopsys dot com>
- Date: Tue, 28 Mar 2017 14:27:10 +0100
- Subject: Re: [PATCH 4/5 v2] arc: Add disassembler helper
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 855EB4E05F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 855EB4E05F
- References: <20170315151738.28651-1-Anton.Kolesov@synopsys.com>
On 03/15/2017 03:17 PM, Anton Kolesov wrote:
> yyyy-mm-dd Anton Kolesov <anton.kolesov@synopsys.com>
>
> * configure.tgt: Add arc-insn.o.
> * arc-tdep.c (arc_delayed_print_insn): Make non-static.
> (dump_arc_instruction_command): New function.
> (arc_fprintf_disasm): Likewise.
> (arc_disassemble_info): Likewise.
> (arc_insn_get_operand_value): Likewise.
> (arc_insn_get_operand_value_signed): Likewise.
> (arc_insn_get_memory_base_reg): Likewise.
> (arc_insn_get_memory_offset): Likewise.
> (arc_insn_get_branch_target): Likewise.
> (arc_insn_dump): Likewise.
> (arc_insn_get_linear_next_pc): Likewise.
> * arc-tdep.h (arc_delayed_print_insn): Add function declaration.
> (arc_disassemble_info): Likewise.
> (arc_insn_get_branch_target): Likewise.
> (arc_insn_get_linear_next_pc): Likewise.
> * NEWS: Mention new "maint print arc arc-instruction".
Indentation is odd above. Be sure to only have a leading
tab on the lines that start with "(", not tab + 2 spaces.
> +; This testcase is part of GDB, the GNU debugger.
> +
> +; Copyright 2017 Synopsys Inc.
> +
s/Synopsys/FSF/g? I noticed it in patch 5/5 too. Didn't
confirm others. Please double check the whole series.
Otherwise I have no further comments. LGTM.
Thanks,
Pedro Alves