This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove MAX_REGISTER_SIZE from target.c
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>,
- Date: Fri, 24 Mar 2017 15:59:22 +0000
- Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from target.c
- Authentication-results: sourceware.org; auth=none
- References: <CF801F56-59C3-4A53-9309-2AC05D7C8501@arm.com> <868toorjwz.fsf@gmail.com> <BA5146DE-FFC0-41C7-93EA-7AB1498E8AE7@arm.com>
Alan Hayward <Alan.Hayward@arm.com> writes:
Hi Alan,
Patch is good to me, a nit below,
> + int i, size = register_size (gdbarch, regno);
move "int i" ...
> + gdb_byte *buf = register_buffer (regcache, regno);
> +
> + fprintf_unfiltered (gdb_stdlog, " = ");
> + for (i = 0; i < size; i++)
... here, for (int i = 0; ....
--
Yao (齐尧)