This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Avoid segfault on invalid directory table


Hi Pádraig,

On 03/24/2017 04:09 AM, Padraig Brady wrote:
> gdb was segfaulting during backtrace on a binary here,
> where fe->dir_index parsed from the dwarf info was seen to
> access beyond the provided include_dirs array.
> The attached bounds the access to entries actually written to the array,
> and was verified to output the backtrace correctly.
> 

Thanks, I pushed it.

Note that AFAICS, Facebook has as couple copyright assignments in place,
but none covers you for GDB.  The patch was sufficiently small that it
shouldn't be a problem this time.  But it'd be appreciated if that
was sorted out if you plan on contributing more.

And also, could you give this patch a try? :

  https://sourceware.org/ml/gdb-patches/2017-03/msg00444.html

(I see now that I mistakenly named you as author of that commit.
Sorry about that.  I've fixed it locally.  :-) )

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]