This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64


    > Very nice!  Feel free to push with a couple nits below fixed.
    >
    >> diff --git a/gdb/testsuite/gdb.arch/sparc64-regs.exp b/gdb/testsuite/gdb.arch/sparc64-regs.exp
    >> new file mode 100644
    >> index 0000000..fff9964
    >> --- /dev/null
    >> +++ b/gdb/testsuite/gdb.arch/sparc64-regs.exp
    >> @@ -0,0 +1,117 @@
    >> +# Copyright 2017-2017 Free Software Foundation, Inc.
    >
    > Single "2017".
    >
    >> +##########################################
    >> +set lno [gdb_get_line_number "sparc64-regs.exp: after first %fsr" $srcfile]
    >> +gdb_test "break $srcfile:$lno" "Breakpoint \[0-9\] at .*"
    >
    > Give this gdb_test a 3rd parameter that avoids showing the line
    > number in gdb.sum, to avoid spurious/unnecessary gdb.sum change
    > if/when the test source changes.
    
    Thank you for your comments.
    Attached is the changed patch and ChangeLog entries.
    I will ask Jose to push the changes on my behalf as I don't have write
    access to the binutils-gdb repository.
    
Pushed.
Salud!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]