This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Mon, 20 Mar 2017 22:06:11 +0000
- Subject: Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 20732C0092C1
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 20732C0092C1
- References: <e7dd381e-4a3d-83a2-930b-25758f44f81b@redhat.com> <20170320215147.25887-1-simon.marchi@ericsson.com>
On 03/20/2017 09:51 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> New in v2: use scoped_restore to save/restore inferior_ptid.
>
> The implementations of to_fetch_regiters/to_store_registers in the spu
Typo: "regiters".
> code use some functions that rely on inferior_ptid. It's simpler for
> now to set/restore inferior_ptid.
>
> * spu-linux-nat.c (spu_fetch_inferior_registers,
> spu_store_inferior_registers): Use ptid from regcache, set and
> restore inferior_ptid.
> * spu-multiarch.c (spu_fetch_registers, spu_store_registers):
> Likewise.
LGTM.
Thanks,
Pedro Alves