This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix spurious FAILs with examine-backward.exp


On 03/20/2017 05:14 PM, Andreas Arnez wrote:
> The test case examine-backward.exp issues the command "x/-s" after the end
> of the first string in TestStrings, but without making sure that this
> string is preceded by a string terminator.  Thus GDB may spuriously print
> some random characters from before that string, and then the test fails.
> 
> This patch assures that TestStrings is preceded by a string terminator.
> 

Agreed.  Looks like I forgot to follow through with:

 https://sourceware.org/ml/gdb-patches/2016-08/msg00127.html

>  
> +const char Barrier[] = {
> +  0x00,
> +};
> +

OK with a comment.  Feel free to steal mine from that url.

>  const char TestStrings[] = {
>    0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48,
>    0x49, 0x4a, 0x4b, 0x4c, 0x4d, 0x4e, 0x4f, 0x50,
> 

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]