This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch v5] Add -file-list-shared-libraries MI command
- From: Pedro Alves <palves at redhat dot com>
- To: Marc-Andre Laperle <marc-andre dot laperle at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 17 Mar 2017 16:55:23 +0000
- Subject: Re: [Patch v5] Add -file-list-shared-libraries MI command
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C9A0E6AAE2
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C9A0E6AAE2
- References: <838tooorew.fsf@gnu.org> <20170302145500.10230-1-marc-andre.laperle@ericsson.com>
On 03/02/2017 02:55 PM, Marc-Andre Laperle wrote:
> -The corresponding @value{GDBN} command is @samp{info shared}.
> +The corresponding @value{GDBN} command is @samp{info shared}. The fields
> +have a similar meaning to the @code{=library-loaded} notification.
> +The @code{ranges} field specifies the muliple segments belonging to this
Typo "muliple".
> /* Record the range of addresses belonging to this shared library.
> There may not be just one (e.g. if two segments are relocated
> - differently); but this is only used for "info sharedlibrary". */
> + differently). This is used for "info sharedlibrary" and
> + the MI command "-file-list-shared-libraries". The later has a format
Typo: "latter".
> + that supports outputting multiple segments once the related code
> + supports them. */
> CORE_ADDR addr_low, addr_high;
> };
>
Fix those, and you're good to go. Please push.
Thanks,
Pedro Alves