This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64
- From: Pedro Alves <palves at redhat dot com>
- To: Ivo Raisr <ivo dot raisr at oracle dot com>, gdb-patches at sourceware dot org
- Date: Fri, 17 Mar 2017 16:42:05 +0000
- Subject: Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 805EB7AE95
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 805EB7AE95
- References: <37ce765b-9064-a766-c843-a25b69030528@oracle.com> <705eae25-cf4e-fc81-dd8e-1e622b340486@oracle.com> <bb05a51e-775a-a33f-84e0-89b918fec6c6@oracle.com> <118a1bb4-80c3-3458-26ae-de3248a82dea@oracle.com>
On 03/14/2017 08:37 AM, Ivo Raisr wrote:
> Ping II.
> Can I get +1 for this small patch?
> I.
I was hoping that someone who actually knows sparc would
take a look. :-)
My only comment would be wondering about a adding some test.
E.g., some small assembly test in gdb.arch/ that you'd single-step
and make sure that the expected changes can be observed in
the affected registers / flags.
Thanks,
Pedro Alves