This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Create MI commands using python.


Hi Didier, sorry for the delay.

On 02/10/2017 08:40 PM, Didier Nadeau wrote:
> This commit allows an user to create custom MI commands using Python
> similarly to what is possible for Python CLI commands.
> 
> A new subclass of mi_command is defined for Python MI commands,
> mi_command_py. A new file, py-micmd.c contains the logic for Python
> MI commands.

Thanks for posting the Python patch.  I suppose nobody
else commented thus far because this is missing a few things,
without which it is hard to review / understand / accept the patch.

#1 - An introduction.

 Some kind of rationale for why this is a desirable feature.  "Sell" 
 the feature, Make us way to "buy" it.  What is the intended use case?
 What do scripts supposedly look like?  How are scripts going to
 emit MI?  I suppose they'll build the MI output "manually" ?

#2 - Manual.

 A change to the manual to document the new APIs, and intended use cases.

#3 - Testsuite.

 New tests covering the new API.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]