This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Create MI commands using python.
- From: Pedro Alves <palves at redhat dot com>
- To: Didier Nadeau <didier dot nadeau at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 17 Mar 2017 15:38:54 +0000
- Subject: Re: [PATCH] Create MI commands using python.
- Authentication-results: sourceware.org; auth=none
- References: <CAK0EQJGWrqcx_dYTWaYxJvwgkoigZW=ECVUFHty_=Gg2nD_gsw@mail.gmail.com> <1486759253-26582-1-git-send-email-didier.nadeau@gmail.com>
Hi Didier, sorry for the delay.
On 02/10/2017 08:40 PM, Didier Nadeau wrote:
> This commit allows an user to create custom MI commands using Python
> similarly to what is possible for Python CLI commands.
>
> A new subclass of mi_command is defined for Python MI commands,
> mi_command_py. A new file, py-micmd.c contains the logic for Python
> MI commands.
Thanks for posting the Python patch. I suppose nobody
else commented thus far because this is missing a few things,
without which it is hard to review / understand / accept the patch.
#1 - An introduction.
Some kind of rationale for why this is a desirable feature. "Sell"
the feature, Make us way to "buy" it. What is the intended use case?
What do scripts supposedly look like? How are scripts going to
emit MI? I suppose they'll build the MI output "manually" ?
#2 - Manual.
A change to the manual to document the new APIs, and intended use cases.
#3 - Testsuite.
New tests covering the new API.
Thanks,
Pedro Alves