This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] Fix some aspects of python lazy string handling: scheme
- From: "Doug Evans via gdb-patches" <gdb-patches at sourceware dot org>
- To: gdb-patches <gdb-patches at sourceware dot org>, Eli Zaretskii <eliz at gnu dot org>, Phil Muldoon <pmuldoon at redhat dot com>
- Date: Thu, 16 Mar 2017 09:58:36 -0700
- Subject: Re: [PATCH 4/4] Fix some aspects of python lazy string handling: scheme
- Authentication-results: sourceware.org; auth=none
- References: <001a1134f356f7dc0a0540abd070@google.com>
- Reply-to: Doug Evans <dje at google dot com>
On Sun, Nov 6, 2016 at 5:19 PM, Doug Evans <dje@google.com> wrote:
> Hi. This is the scheme equivalent of the python fixes.
>
> 2016-11-06 Doug Evans <dje@google.com>
>
> * guile/scm-lazy-string.c (lazy_string_smob): Clarify use of LENGTH
> member. Change type of TYPE member to SCM. All uses updated.
> (lsscm_make_lazy_string_smob): Add assert.
> (lsscm_make_lazy_string): Flag bad length values.
> (lsscm_elt_type): New function.
> (gdbscm_lazy_string_to_value): Rewrite to use
> lsscm_safe_lazy_string_to_value.
> (lsscm_safe_lazy_string_to_value): Fix handling of TYPE_CODE_PTR.
> * guile/scm-value.c (gdbscm_value_to_lazy_string): Flag bad length
> values. Fix TYPE_CODE_PTR. Handle TYPE_CODE_ARRAY. Handle
> typedefs
> in incoming type.
> * guile/guile-internal.h (tyscm_scm_to_type): Declare.
> * guile/scm-type.c (tyscm_scm_to_type): New function.
>
> testsuite/
> * gdb.guile/scm-value.c (main) Delete locals sptr, sn.
> * gdb.guile/scm-lazy-string.c: New file.
> * gdb.guile/scm-value.exp: Move lazy string tests to ...
> * gdb.guile/scm-lazy-string.exp: ... here, new file. Add more tests
> for pointer, array, typedef lazy strings.
Rebased, re-regression tested on amd64-linux, and committed.
[I'll post the committed patch as soon as I can get sendmail on my box
working again, bleah. We still don't allow attachments do we?]