This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word


Jiong Wang <jiong.wang@foss.arm.com> writes:

> I am seeing the following build failure on my local AArch32 native build:
>
> ...binutils-gdb/gdb/inf-ptrace.c:473:65: error: no matching function
> for call to 'min(unsigned int, ULONGEST)'
>
> There are a few ways to fix this, this patch simply change the type of
> "skip" from "unsigned int" to "ULONGEST" so operands for std::min can
> have the same type.
>
> OK for master?
>

Yes, pleas apply, a nit below,

> gdb/
> 2017-03-16  Jiong Wang  <jiong.wang@arm.com>
>
>         * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to "ULONGEST" for

This line is too long.  The max line length of ChangeLog is 74.

>         "skip".


-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]