This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PING][PATCH] gdb.base/siginfo-thread.exp: Increase timeout for 'gcore' command


Wei-min Pan wrote:
The following failed lines from running test case siginfo-thread:

FAIL: gdb.base/siginfo-thread.exp: save a core file (timeout)
FAIL: gdb.base/siginfo-thread.exp: extract si_addr
FAIL: gdb.base/siginfo-thread.exp: p ssi_addr

indicate the testsuite timed out when gdb was instructed to write the
core file. The patch below fixes the problem by simply increasing the
timeout by a factor of 2 to give gdb more time to generate core files.

Tested in sparc64-linux-gnu. No regressions.

       * gdb.base/siginfo-thread.exp: Increase timeout by a factor of 2
       for the 'gcore command.
---
gdb/testsuite/gdb.base/siginfo-thread.exp |   20 +++++++++++---------
1 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/gdb/testsuite/gdb.base/siginfo-thread.exp b/gdb/testsuite/gdb.base/
siginfo-thread.exp
index 825a0d2..872780b 100644
--- a/gdb/testsuite/gdb.base/siginfo-thread.exp
+++ b/gdb/testsuite/gdb.base/siginfo-thread.exp
@@ -44,15 +44,17 @@ if { ![runto_main] } then {
gdb_test "continue" "Thread .* received signal SIGSEGV.*" "continue to signal"

# Try to generate a core file, for a later test.
-set gcorefile [standard_output_file $testfile.gcore]
-set gcore_created [gdb_gcore_cmd $gcorefile "save a core file"]
-
-set ssi_addr ""
-set test "extract si_addr"
-gdb_test_multiple "p \$_siginfo" "$test" {
-    -re "si_addr = ($hex).*$gdb_prompt $" {
-       set ssi_addr $expect_out(1,string)
-       pass "$test"
+with_timeout_factor 2 {
+    set gcorefile [standard_output_file $testfile.gcore]
+    set gcore_created [gdb_gcore_cmd $gcorefile "save a core file"]
+
+    set ssi_addr ""
+    set test "extract si_addr"
+    gdb_test_multiple "p \$_siginfo" "$test" {
+       -re "si_addr = ($hex).*$gdb_prompt $" {
+           set ssi_addr $expect_out(1,string)
+           pass "$test"
+       }
    }
}

--
1.7.1




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]