This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Tue, 14 Mar 2017 17:13:53 +0000
- Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
- Authentication-results: sourceware.org; auth=none
- References: <m3bmt3eucs.fsf@oc1027705133.ibm.com>
On 03/14/2017 03:44 PM, Andreas Arnez wrote:
> Version 1 is here:
>
> https://sourceware.org/ml/gdb-patches/2017-03/msg00043.html
>
> Changes from version 1:
>
> * "unsigned" -> "unsigned int"
>
> * Compare pointers with NULL explicitly.
Pedantically, it should be "if (errno != 0)" and
"*xfered_len != 0 ? ...." as well.
>
> * Move the ptrace peek/poke loop to a separate routine for better
> readability.
>
> OK to apply?
LGTM.
Thanks,
Pedro Alves