This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v1.99 0/6] Make register fetch/store implementations use ptid from regcache


On 2017-03-13 15:15, Pedro Alves wrote:
On 03/11/2017 05:03 PM, Simon Marchi wrote:
This is almost a v2 of:

  Pass ptid to target_ops register methods
  https://sourceware.org/ml/gdb-patches/2017-03/msg00100.html

but since the work can be done incrementally (unlike the original version), I'd like to make sure that the idea is good before proceeding with all the changes. I've only done changes to a few target files for the moment and will do the
others if these look good..

LGTM.

Thanks, pushed.

[ I'd also be fine with moving the struct regcache definition to the
header in order to add a regcache::ptid() method.  :-) ]

Well, if we move the struct to the header, we don't need a ptid method, since the field is public :). But yeah, it would be an obvious candidate for cxx-ification.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]