This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/7] Pass ptid to target_fetch_registers


On 17-03-08 11:41 AM, Simon Marchi wrote:
> This patch adds a ptid parameter to the target_fetch_registers and the
> to_fetch_registers method of target_ops.  The implementations are
> therefore expected to rely on this and not on inferior_ptid.

I managed to build GDB on FreeBSD, and it showed I had forgotten a few spots
in bsd-kvm.c.  Consider this diff to be part of the patch as well:

diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
index 7ca59ba2b9..2eac0d5289 100644
--- a/gdb/bsd-kvm.c
+++ b/gdb/bsd-kvm.c
@@ -98,7 +98,7 @@ bsd_kvm_open (const char *arg, int from_tty)
   add_thread_silent (bsd_kvm_ptid);
   inferior_ptid = bsd_kvm_ptid;

-  target_fetch_registers (get_current_regcache (), -1);
+  target_fetch_registers (get_current_regcache (), inferior_ptid, -1);

   reinit_frame_cache ();
   print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
@@ -297,7 +297,7 @@ bsd_kvm_proc_cmd (char *arg, int fromtty)
   if (kvm_read (core_kd, addr, &bsd_kvm_paddr, sizeof bsd_kvm_paddr) == -1)
     error (("%s"), kvm_geterr (core_kd));

-  target_fetch_registers (get_current_regcache (), -1);
+  target_fetch_registers (get_current_regcache (), inferior_ptid, -1);

   reinit_frame_cache ();
   print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);
@@ -317,7 +317,7 @@ bsd_kvm_pcb_cmd (char *arg, int fromtty)

   bsd_kvm_paddr = (struct pcb *)(u_long) parse_and_eval_address (arg);

-  target_fetch_registers (get_current_regcache (), -1);
+  target_fetch_registers (get_current_regcache (), inferior_ptid, -1);

   reinit_frame_cache ();
   print_stack_frame (get_selected_frame (NULL), 0, SRC_AND_LOC, 1);



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]