This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove MAX_REGISTER_SIZE from sol-thread.c
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Alan Hayward <Alan dot Hayward at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 1 Mar 2017 12:24:00 -0500
- Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from sol-thread.c
- Authentication-results: sourceware.org; auth=none
- References: <9C2B8A71-1050-4B8B-A27A-C620E46AB9A2@arm.com> <86d1e0rkam.fsf@gmail.com>
Hi -
>
> > Regcache calls in sol-thread.c are bogus and do nothing.
> > The code in between will not change or update regcache.
> > Removed.
>
> If we remove code, we need to figure out why the code was there.
> The code is about to remove was added by
>
> commit 7cdd6cac82faad2083029b2ac014d44d869f76c0
> Author: Frank Ch. Eigler <fche@redhat.com>
> Date: Thu Apr 2 18:54:04 1998 +0000
>
> * Fixes for PR 14571.
> [...]
Heh, sorry, my recollection of this after 19 years is totally blank.
Interestingly, PR14571 must refer to the pre-bugzilla bug tracker
system. There was one on sourceware.org, but its web interface is no
longer operating, and scraps of the database files that are still
archived seem not to go up to 14571. Likewise, no google hits.
So I'm at a loss, can't find orginal supporting data either, and
that's a bummer.
- FChE