This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support


On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote:
What about gdb.arch/ppc64-isa207-atomic-inst.*?


Could be. I don't have a better suggestion. Maybe Ulrich has.

Thus, I'm keeping the runtime check using HWCAP2 bits for now.

Please let me know if there are any additional fixes to do.

Just a nit.

diff --git a/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp
new file mode 100644
index 0000000..2b4c8ad
--- /dev/null
+++ b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp

...

+if {![istarget "powerpc*"] || ![is_lp64_target]} {
+    verbose "Skipping testing of powerpc64 single stepping over atomic sequences."

untested "skipping powerpc isa 207 atomic sequences test"?

Otherwise i have no further comments.

Thanks,
Luis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]