This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] gdb: xtensa-linux: support THREADPTR register
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>, Marc Gauthier <marc at cadence dot com>
- Date: Tue, 14 Feb 2017 01:06:36 -0800
- Subject: Re: [PATCH 1/2] gdb: xtensa-linux: support THREADPTR register
- Authentication-results: sourceware.org; auth=none
- References: <1484783816-13856-1-git-send-email-jcmvbkbc@gmail.com> <1484783816-13856-2-git-send-email-jcmvbkbc@gmail.com> <cd95f77c-130e-2166-2e63-73a4006fc900@codesourcery.com>
On Mon, Feb 13, 2017 at 10:17 AM, Luis Machado
<lgustavo@codesourcery.com> wrote:
> On 01/18/2017 05:56 PM, Max Filippov wrote:
>>
>> Make THREADPTR user register accessible.
>>
>> 2017-01-18 Max Filippov <jcmvbkbc@gmail.com>
>> gdb/
>
>
> Drop gdb/ from the ChangeLog.
It's the commit message, not the actual ChangeLog.
I see that specifying location of the ChangeLog file where a section
of the commit message goes is common practice, is it considered bad?
Of course I will not put it to the ChangeLog.
>> diff --git a/gdb/xtensa-tdep.c b/gdb/xtensa-tdep.c
>> index 797e728..2c3e41e 100644
>> --- a/gdb/xtensa-tdep.c
>> +++ b/gdb/xtensa-tdep.c
>> @@ -3120,6 +3120,7 @@ xtensa_derive_tdep (struct gdbarch_tdep *tdep)
>>
>> /* Special registers 0..255 (core). */
>> #define XTENSA_DBREGN_SREG(n) (0x0200+(n))
>> +#define XTENSA_DBREGN_UREG(n) (0x0300+(n))
>
>
> Maybe add a little comment about what UREG is and its use?
Will add.
> Otherwise i have no further comments on this particular patch.
--
Thanks.
-- Max