This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/5] Remove some ui_out-related cleanups from Python
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Trevor Saunders <tbsaunde at tbsaunde dot org>, gdb-patches at sourceware dot org
- Date: Wed, 8 Feb 2017 23:51:57 +0000
- Subject: Re: [RFA 1/5] Remove some ui_out-related cleanups from Python
- Authentication-results: sourceware.org; auth=none
- References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-2-tom@tromey.com> <20170116113021.sar3yh5ivykpqmbw@ball> <c0a70339-49c3-a087-bebf-ecfdd2cc32ca@redhat.com> <87inok708e.fsf@tromey.com>
On 02/08/2017 11:04 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> One difficulty with putting such a thing at the top level is that
> Pedro> gdb relies on gnulib headers (that exist under gdb/) while
> Pedro> other toolchain components don't, yet, at least.
>
> gnulib should just be at top-level, but I realize that's a pain.
>
> Pedro> It probably does make sense to start with something simpler and
> Pedro> upgrade when/if we find a need. OTOH, looks like the current patch
> Pedro> doesn't have accessors for the wrapped value, so it seems like we'll
> Pedro> at least need to be extend it in that direction in no time.
>
> I had forgotten about this code. I don't mind using it instead.
Let's start with your version, and leave the door open. The version I have
would need a bit of cleaning, re-checking if GCC's implementation changed
meanwhile (ISTR there have been recent patches to address some DRs), check
that it compiles against clang and older gcc's (4.8, etc.). I already have too
many balls in the air ATM.
> Pedro> Patch LGTM with Trevor's and Simon's nits addressed.
>
> I have that done locally, but I've just been waiting until your series
> lands, so I can rebase. And then maybe the option stuff wouldn't be
> needed anyway? I don't remember the details from your branch, I was
> just waiting for the big rebase to find out.
My series is all in master. I think we'll still need your patch, since I only
touched ui_files. I haven't done anything with ui_out list/tuple building.
Thanks,
Pedro Alves