This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/5] Remove some ui_out-related cleanups from Python
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Trevor Saunders <tbsaunde at tbsaunde dot org>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 08 Feb 2017 16:04:49 -0700
- Subject: Re: [RFA 1/5] Remove some ui_out-related cleanups from Python
- Authentication-results: sourceware.org; auth=none
- References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-2-tom@tromey.com> <20170116113021.sar3yh5ivykpqmbw@ball> <c0a70339-49c3-a087-bebf-ecfdd2cc32ca@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> One difficulty with putting such a thing at the top level is that
Pedro> gdb relies on gnulib headers (that exist under gdb/) while
Pedro> other toolchain components don't, yet, at least.
gnulib should just be at top-level, but I realize that's a pain.
Pedro> It probably does make sense to start with something simpler and
Pedro> upgrade when/if we find a need. OTOH, looks like the current patch
Pedro> doesn't have accessors for the wrapped value, so it seems like we'll
Pedro> at least need to be extend it in that direction in no time.
I had forgotten about this code. I don't mind using it instead.
Pedro> Patch LGTM with Trevor's and Simon's nits addressed.
I have that done locally, but I've just been waiting until your series
lands, so I can rebase. And then maybe the option stuff wouldn't be
needed anyway? I don't remember the details from your branch, I was
just waiting for the big rebase to find out.
Tom