Re: [PATCH] Bug 20936 - provide sparc and sparcv9 target description XML files

[Yao Qi <qiyaoltc at gmail dot com>]

On 17-01-17 22:37:59, Ivo Raisr wrote:
> diff -Nupr a/gdb/doc/gdb.texinfo gdb-7.11/gdb/doc/gdb.texinfo
> --- a/gdb/doc/gdb.texinfo	2016-02-24 01:55:15.000000000 +0000
> +++ gdb-7.11/gdb/doc/gdb.texinfo	2017-01-17 04:51:21.533190029 +0000
> @@ -40658,6 +40658,7 @@ registers using the capitalization used
>  * Nios II Features::
>  * PowerPC Features::
>  * S/390 and System z Features::
> +* Sparc Features::
>  * TIC6x Features::
>  @end menu
>  
> @@ -40945,6 +40946,48 @@ through @samp{f15} to present the 128-bi
>  contain the 128-bit wide vector registers @samp{v16} through
>  @samp{v31}.
>  
> +@node Sparc Features
> +@subsection Sparc Features
> +@cindex target descriptions, sparc32 features
> +@cindex target descriptions, sparc64 features
> +The @samp{org.gnu.gdb.sparc.cpu} feature is required for sparc32/sparc64
> +targets.  It should describe the following registers:
> +
> +@itemize @minus
> +@item
> +@samp{g0} through @samp{g7}
> +@item
> +@samp{o0} through @samp{o7}
> +@item
> +@samp{l0} through @samp{l7}
> +@item
> +@samp{i0} through @samp{i7}
> +@end itemize
> +
> +They may be 32-bit or 64-bit depending on the target.
> +
> +Also the @samp{org.gnu.gdb.sparc.fpu} feature is required for sparc32/sparc64
> +targets.  It should describe the following registers:
> +
> +@itemize @minus
> +@item
> +@samp{f0} through @samp{f31}
> +@item
> +@samp{f32} through @samp{f62} for sparc64
> +@end itemize
> +
> +The @samp{org.gnu.gdb.sparc.cp0} feature is required for sparc32/sparc64
> +targets.  It should describe the following registers:
> +
> +@itemize @minus
> +@item
> +@samp{y}, @samp{psr}, @samp{wim}, @samp{tbr}, @samp{pc}, @samp{npc},
> +@samp{fsr}, and @samp{csr} for sparc32
> +@item
> +@samp{pc}, @samp{npc}, @samp{state}, @samp{fsr}, @samp{fprs}, and @samp{y}
> +for sparc64
> +@end itemize
> +
>  @node TIC6x Features
>  @subsection TMS320C6x Features
>  @cindex target descriptions, TIC6x features

If the doc hasn't been reviewed before, it needs a doc review.

> diff -Nupr a/gdb/features/sparc/sparc32-cp0.xml gdb-7.11/gdb/features/sparc/sparc32-cp0.xml
> --- a/gdb/features/sparc/sparc32-cp0.xml	1969-12-31 16:00:00.000000000 +0000
> +++ gdb-7.11/gdb/features/sparc/sparc32-cp0.xml	2017-01-17 04:51:21.534235184 +0000
> @@ -0,0 +1,19 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2013-2016 Free Software Foundation, Inc.

Why does the year range start from 2013?  It should end on 2017, anyway.

> +
> +     Copying and distribution of this file, with or without modification,
> +     are permitted in any medium without royalty provided the copyright
> +     notice and this notice are preserved.  -->
> +

non-doc bits of this patch look good to me.

-- 
Yao