Re: [PATCH 3/6] Call print_insn_mep in mep_gdb_print_insn

[Luis Machado <lgustavo at codesourcery dot com>]

On 01/24/2017 04:08 AM, Yao Qi wrote:
> On 17-01-17 08:19:18, Luis Machado wrote:
> > On 01/16/2017 04:02 AM, Yao Qi wrote:
> > > -/* The mep disassembler needs to know about the section in order to
> > > -   work correctly.  */
> >
> > Instead of removing the comment, should we point out what the
> > effects of having/not having section info will be?
>
> That is the implementation detail of print_insn_mep (provided by opcodes),
> and gdb should not know about.  Both gdb and objdump are the clients of
> opcodes, and they need to provide precise information as much as it can.
> However, they shouldn't know that what should print_insn_mep do.

Fair enough. But in that case we still have a chunk of code in that 
function explaining why the section is being used. Should that go away too?

      /* The libopcodes disassembly code uses the section to find the
         BFD, the BFD to find the ELF header, the ELF header to find
         the me_module index, and the me_module index to select the
         right instructions to print.  */