This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix python-interactive with Python 3.6

From: Pedro Alves <palves at redhat dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 20 Jan 2017 16:51:53 +0000
Subject: Re: [PATCH] Fix python-interactive with Python 3.6
Authentication-results: sourceware.org; auth=none
References: <20170120151550.24928-1-simon.marchi@ericsson.com> <1b7bea3d-3044-a643-d7b9-3b11db14758f@redhat.com> <5989286b709d1361c8bc9062567ffedf@polymtl.ca>

On 01/20/2017 04:48 PM, Simon Marchi wrote:

> Yeah, I thought about that and concluded it would be a problem for my
> grandchildren ;).
> 

;-)

> ... and this is cleaner anyway.  But why not just
> 
> #if python < 3.4
> #define PyMem_RawMalloc PyMem_Malloc
> #endif
> 
> ?

Because I was just copy/pasting from python-internal.h
and didn't really think.  :-)  The other instances in
python-internal.h do it like that because they need to
redefine a symbol, not just define something missing.

Thanks,
Pedro Alves

References:
- [PATCH] Fix python-interactive with Python 3.6
  - From: Simon Marchi
- Re: [PATCH] Fix python-interactive with Python 3.6
  - From: Pedro Alves
- Re: [PATCH] Fix python-interactive with Python 3.6
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]