This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp


On 01/20/2017 03:43 PM, Luis Machado wrote:

>> There's an "unsupported" call inside skip_python_tests.
> 
> Hmm, i was working under the assumption this was a flag. 

Yeah, it's surprising.  I wouldn't mind removing it.  Maybe
make it a "verbose" call instead.

> In this case it
> would make sense to handle all of these checks in the same way and not
> add untested calls, making everything standard.
> I can work on that, but should we drop adding any untested calls in this
> particular patch and only return (until a follow on patch)?

I gave it a second thought, and it's fine with me to add the
untested call, despite the UNSUPPORTED already present in gdb.sum.

Patch is OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]