This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Fri, 20 Jan 2017 15:24:45 +0000
- Subject: Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp
- Authentication-results: sourceware.org; auth=none
- References: <1484923045-16703-1-git-send-email-lgustavo@codesourcery.com>
On 01/20/2017 02:37 PM, Luis Machado wrote:
> Some leftover uppercase test names in py-xmethods.exp. The patch also
> replaces two "continue" calls with untested calls to make things a bit more
> clear.
>
> gdb/testsuite/ChangeLog:
>
> 2017-01-20 Luis Machado <lgustavo@codesourcery.com>
>
> * gdb.python/py-xmethods.exp: Fix test names starting with lowercase
> and add untested calls.
> ---
> gdb/testsuite/gdb.python/py-xmethods.exp | 44 +++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 20 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp
> index 8f5bf16..38b5998 100644
> --- a/gdb/testsuite/gdb.python/py-xmethods.exp
> +++ b/gdb/testsuite/gdb.python/py-xmethods.exp
> @@ -18,7 +18,9 @@
>
> load_lib gdb-python.exp
>
> -if { [skip_cplus_tests] } { continue }
> +if { [skip_cplus_tests] } {
> + untested "skipping C++ tests"
> +}
We still need something that makes the test
actually be skipped.
Thanks,
Pedro Alves