This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve load command's help text


On 01/06/2017 12:29 PM, Simon Marchi wrote:
On 2017-01-06 11:41, Luis Machado wrote:
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 61b9e5b..0af1900 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -3952,7 +3952,8 @@ that lies within the boundaries of this symbol
file in memory."),
   c = add_cmd ("load", class_files, load_command, _("\
 Dynamically load FILE into the running program, and record its
symbols\n\
 for access from GDB.\n\
-A load OFFSET may also be given."), &cmdlist);
+A load offset may also be given.\n\
+Usage: load [FILE] [offset expression]"), &cmdlist);

For consistency, I think this would look better:

  Usage: load [FILE] [OFFSET]

The fact that offset can be an expression can be specified in the text
just before.

That sounds good to me.

Thanks,
Luis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]