This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64 sim bug fix for fcmp and infinity
- From: Nick Clifton <nickc at redhat dot com>
- To: Jim Wilson <jim dot wilson at linaro dot org>, gdb-patches at sourceware dot org
- Date: Wed, 21 Dec 2016 11:34:44 +0000
- Subject: Re: [PATCH] aarch64 sim bug fix for fcmp and infinity
- Authentication-results: sourceware.org; auth=none
- References: <CABXYE2Wr-EQEoV2wCE1QEHB_2mP=uF-BnF-iuhs9UMfTLn6VGw@mail.gmail.com>
Hi Jim,
> Debugging another gcc testsuite failure, I see that fcmp can fail when
> both operands are infinities. The code tries to compute the compare
> result by subtracting operands, but this can yield NaN when both
> operands are inifinities. This is fixed by explicitly checking for
> and handling this case.
>
> While writing the tescase, I noticed that qNan and sNan are not
> handled correctly, but this appears to be broken in more than just the
> compare instructions, so I just added comments to document the problem
> and will leave it to a later patch to fix.
>
> The new testcase fails without the patch, and works with the patch.
> Also, the gcc C testsuite unexpected failures drop from 2627 to 2568.
Approved - please apply - and thanks for the continued testing.
Cheers
Nick