Re: [PATCH v2] Class-ify ui_out

[Pedro Alves <palves at redhat dot com>]

On 12/20/2016 03:28 PM, Simon Marchi wrote:

>>> +  virtual void do_message (const char *format, va_list args) override
>>> +    ATTRIBUTE_PRINTF (2,0) ;
>>> +  virtual void do_wrap_hint (const char *identstring) override;
>>> +  virtual void do_flush () override;
>>> +  virtual int do_redirect (struct ui_file * outstream) override;
>>
>> Should do_redirect return bool?
> 
> Should it return anything at all?  Both implementations always return 0...

Curious.  Guess it wasn't the case at some point.  I checked Insight
too, and its interpreter creates a plain cli_out, not a custom
ui_out, so we're good there too.  I'd push the patch as you had it,
and the clean the method to return void, which will result in some
cascading clean ups at the callers.

Thanks,
Pedro Alves