This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/8] AARCH64 SVE: Initial SVE support
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Hayward <alan dot hayward at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 13 Dec 2016 11:36:31 +0000
- Subject: Re: [PATCH 0/8] AARCH64 SVE: Initial SVE support
- Authentication-results: sourceware.org; auth=none
- References: <D46B0D3D.154CD%alan.hayward@arm.com>
On 16-12-05 12:25:33, Alan Hayward wrote:
> Hi,
>
> I'd like to submit GDB and gdbserver support for ARM's Scalable Vector
> Extension (SVE).
Thanks for your patches...
> In order to support SVE, GDB needs to be able to handle registers which may
> change size at any time whilst the debugged program is running. The target
> architecture descriptions (patch 5) contain a minimum size for each
> variable
> register. GDB (patch 7) and gdbserver (patch 8) must then scale these
> registers
> using the current VG for the target (obtained using ptrace).
> This also requires increasing the maximum register size to 256 bytes
> (patch 1).
There are some coding style issues in patches, some indentation problems,
and spaces after ")", for example.
Your mailer also wrap some lines in the patch, so please fix your mailer
or send patches via git send-email.
There is no ChangeLog entry for each patch, and some rationale are missing
in comments and commit log as well.
--
Yao (齐尧)