This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 1 Dec 2016 12:57:45 +0000
- Subject: Re: [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer
- Authentication-results: sourceware.org; auth=none
- References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <1480591000-19457-1-git-send-email-yao.qi@linaro.org>
On 12/01/2016 11:16 AM, Yao Qi wrote:
> +#if GDB_SELF_TEST
> +
> +namespace selftests
> +{
> +
> + /* Instruction reader from manually cooked instruction sequences. */
> +
> + class instruction_reader_test : public abstract_instruction_reader
> + {
This whole class should be indented at column 0.
> + public:
> + template<size_t SIZE>
> + instruction_reader_test (const uint32_t (&insns)[SIZE])
> + : m_insns (insns), m_insns_size (SIZE)
> + {}
Please add "explicit". Sorry that I missed adding it myself.
Otherwise LGTM.
Thanks,
Pedro Alves