RE: [PATCH v3 2/8] btrace: Export btrace_decode_error function.

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: Wiederhake, Tim
> Sent: Monday, November 21, 2016 4:49 PM
> To: gdb-patches@sourceware.org
> Cc: palves@redhat.com; Metzger, Markus T <markus.t.metzger@intel.com>
> Subject: [PATCH v3 2/8] btrace: Export btrace_decode_error function.
> 
> 2016-11-21  Tim Wiederhake  <tim.wiederhake@intel.com>
> 
> gdb/ChangeLog:
> 
> 	* record-btrace.c (btrace_ui_out_decode_error): Move most of it ...
> 	* btrace.c (btrace_decode_error): ... here.  New function.
> 	* btrace.h (btrace_decode_error): New export.

> +const char *
> +btrace_decode_error (enum btrace_format format, int errcode)
> +{
> +  switch (format)
> +  {
> +    case BTRACE_FORMAT_BTS:

The { is indented and thus goes onto the same column than the case.


Looks good to me, otherwise.

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928