This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v3 1/8] btrace: Count gaps as one instruction explicitly.


> -----Original Message-----
> From: Wiederhake, Tim
> Sent: Monday, November 21, 2016 4:49 PM
> To: gdb-patches@sourceware.org
> Cc: palves@redhat.com; Metzger, Markus T <markus.t.metzger@intel.com>
> Subject: [PATCH v3 1/8] btrace: Count gaps as one instruction explicitly.
> 
> This gives all instructions, including gaps, a unique number.  Add a function
> to retrieve the error code if a btrace instruction iterator points to an
> invalid instruction.
> 
> 2016-11-21  Tim Wiederhake  <tim.wiederhake@intel.com>
> 
> gdb/ChangeLog:
> 
> 	* btrace.c (ftrace_call_num_insn, btrace_insn_get_error): New function.
> 	(ftrace_new_function, btrace_insn_number, btrace_insn_cmp,
> 	btrace_find_insn_by_number): Remove special case for gaps.
> 	* btrace.h (btrace_insn_get_error): New export.
> 	(btrace_insn_number, btrace_find_insn_by_number): Adjust comment.
> 	* record-btrace.c (btrace_insn_history): Print number for gaps.
> 	(record_btrace_info, record_btrace_goto): Handle gaps.


Looks good to me.

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]