This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 04/11] Use gdbpy_enter in python.c
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> LGTM. Formatting nits below.
Pedro> On 11/12/2016 09:28 PM, Tom Tromey wrote:
>> @@ -1885,24 +1870,31 @@ gdbpy_finish_initialization (const struct
>> extension_language_defn *extlang)
>> "Could not load the Python gdb module from `%s'.\n"
>> "Limited Python support is available from the _gdb module.\n"
>> "Suggest passing
>> --data-directory=/path/to/gdb/data-directory.\n"),
>> - gdb_pythondir);
>> - do_cleanups (cleanup);
>> - return;
>> + gdb_pythondir.c_str ());
Pedro> tabs/spaces here?
This one looks a bit funny but it is correct.
The new line replaces the "gdb_pythondir" line, which is indented
incorrectly in the current source.
>> + if (! do_finish_initialization (extlang))
Pedro> No space after '!'.
I've fixed this one.
Tom