This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, v2] Fixup test names starting with uppercase


On 11/15/2016 01:28 PM, Pedro Alves wrote:
On 11/12/2016 05:53 AM, Luis Machado wrote:
This fixes the offender testcases that have test names starting with
uppercase.

I also tried to catch cases where we set the test names via variables.

We should probably adopt a policy and stick with it. If the way to go is
all lowercase, then the following patch should hopefully help clean some
of the inconsistencies up. Otherwise, we should go the other way and adjust
the test names to start with uppercase.

I agree with lowercase.  It's what we use most pervasively, and I've
asked people to lowercase messages in review in the past.  The fewer
(bad) examples people can crib from, the better.  So thanks for doing this.


Great. I'll polish the regular expression and i'll try to catch more offenders.

While at it, do we also want to lowercase debugging messages emitted from perror/error/warning/verbose etc? I could do that in a separate patch.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]